Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update dart:io tests to use asyncStart/asyncEnd R=ajohnsen@google.com BUG=http://dartbug.com/12977 Committed: https://code.google.com/p/dart/source/detail?r=27054

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -565 lines) Patch
M tests/standalone/io/async_catch_errors_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/delete_symlink_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_chdir_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/directory_create_race_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_error_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/io/directory_fuzz_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tests/standalone/io/directory_invalid_arguments_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_list_nonexistent_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/standalone/io/directory_list_pause_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_non_ascii_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 16 chunks +19 lines, -18 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 19 chunks +48 lines, -73 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 13 chunks +13 lines, -13 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/file_non_ascii_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/file_output_stream_test.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M tests/standalone/io/file_stat_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/file_system_async_links_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/file_test.dart View 17 chunks +34 lines, -63 lines 0 comments Download
M tests/standalone/io/file_typed_data_test.dart View 10 chunks +21 lines, -20 lines 0 comments Download
M tests/standalone/io/file_write_as_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/http_client_connect_test.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M tests/standalone/io/http_client_exception_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 2 chunks +14 lines, -13 lines 0 comments Download
M tests/standalone/io/http_reuse_server_port_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/standalone/io/http_server_test.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/https_client_exception_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/standalone/io/link_async_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/process_environment_test.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M tests/standalone/io/process_non_ascii_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/process_pid_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 7 chunks +12 lines, -11 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 8 chunks +20 lines, -18 lines 0 comments Download
M tests/standalone/io/raw_server_socket_cancel_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/raw_socket_test.dart View 11 chunks +25 lines, -25 lines 0 comments Download
M tests/standalone/io/raw_socket_typed_data_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/regress_10026_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_builtin_roots_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 5 chunks +12 lines, -11 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 7 chunks +12 lines, -11 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 8 chunks +22 lines, -19 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_data_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 4 chunks +8 lines, -10 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 4 chunks +14 lines, -7 lines 0 comments Download
M tests/standalone/io/socket_ipv6_test.dart View 8 chunks +16 lines, -5 lines 0 comments Download
M tests/standalone/io/socket_test.dart View 15 chunks +27 lines, -25 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 1 7 chunks +9 lines, -12 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M tests/standalone/io/windows_file_system_async_links_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/standalone/io/zlib_test.dart View 9 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-03 11:00:25 UTC) #1
Anders Johnsen
LGTM, nice cleanup. https://codereview.chromium.org/23886004/diff/1/tests/standalone/io/stream_pipe_test.dart File tests/standalone/io/stream_pipe_test.dart (right): https://codereview.chromium.org/23886004/diff/1/tests/standalone/io/stream_pipe_test.dart#newcode172 tests/standalone/io/stream_pipe_test.dart:172: asyncStart(); I fail to see the ...
7 years, 3 months ago (2013-09-03 11:43:03 UTC) #2
Søren Gjesse
https://codereview.chromium.org/23886004/diff/1/tests/standalone/io/stream_pipe_test.dart File tests/standalone/io/stream_pipe_test.dart (right): https://codereview.chromium.org/23886004/diff/1/tests/standalone/io/stream_pipe_test.dart#newcode172 tests/standalone/io/stream_pipe_test.dart:172: asyncStart(); On 2013/09/03 11:43:03, Anders Johnsen wrote: > I ...
7 years, 3 months ago (2013-09-03 13:39:25 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-09-03 13:44:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r27054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698