Update dart:io tests to use asyncStart/asyncEnd

tests/standalone/io/file_error_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing error handling in file I/O.
 
-import "package:expect/expect.dart";
 import "dart:convert";
 import "dart:io";
-import "dart:isolate";
+
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
 
 Directory tempDir() {
   return new Directory('').createTempSync();
 }
 
 
 bool checkNonExistentFileException(e, str) {
   Expect.isTrue(e is FileException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf(str) != -1);
@@ skipping 12 matching lines @@
   return checkNonExistentFileException(e, "Cannot delete file");
 }
 
 
 bool checkLengthNonExistentFileException(e) {
   return checkNonExistentFileException(e, "Cannot retrieve length of file");
 }
 
 
 void testOpenNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.openSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   var openFuture = file.open(mode: FileMode.READ);
   openFuture.then((raf) => Expect.fail("Unreachable code"))
             .catchError((error) {
               checkOpenNonExistentFileException(error);
-              p.toSendPort().send(null);
+              temp.deleteSync(recursive: true);
+              asyncEnd();
             });
 }
 
 
 void testDeleteNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.deleteSync(),
                 (e) => checkDeleteNonExistentFileException(e));
 
   var delete = file.delete();
   delete.then((ignore) => Expect.fail("Unreachable code"))
         .catchError((error) {
           checkDeleteNonExistentFileException(error);
-          p.toSendPort().send(null);
+          temp.deleteSync(recursive: true);
+          asyncEnd();
         });
 }
 
 
 void testLengthNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.lengthSync(),
                 (e) => checkLengthNonExistentFileException(e));
 
   var lenFuture = file.length();
   lenFuture.then((len) => Expect.fail("Unreachable code"))
            .catchError((error) {
              checkLengthNonExistentFileException(error);
-             p.toSendPort().send(null);
+             temp.deleteSync(recursive: true);
+             asyncEnd();
            });
 }
 
 
 bool checkCreateInNonExistentDirectoryException(e) {
   Expect.isTrue(e is FileException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf("Cannot create file") != -1);
   if (Platform.operatingSystem == "linux") {
     Expect.equals(2, e.osError.errorCode);
   } else if (Platform.operatingSystem == "macos") {
     Expect.equals(2, e.osError.errorCode);
   } else if (Platform.operatingSystem == "windows") {
     Expect.equals(3, e.osError.errorCode);
   }
 
   return true;
 }
 
 void testCreateInNonExistentDirectory() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentDirectory/newFile");
 
   // Create in non-existent directory should throw exception.
   Expect.throws(() => file.createSync(),
                 (e) => checkCreateInNonExistentDirectoryException(e));
 
   var create = file.create();
   create.then((ignore) => Expect.fail("Unreachable code"))
   .catchError((error) {
     checkCreateInNonExistentDirectoryException(error);
-    p.toSendPort().send(null);
+    temp.deleteSync(recursive: true);
+    asyncEnd();
   });
 }
 
 bool checkFullPathOnNonExistentDirectoryException(e) {
   Expect.isTrue(e is FileException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.toString().indexOf("Cannot retrieve full path") != -1);
   // File not not found has error code 2 on all supported platforms.
   Expect.equals(2, e.osError.errorCode);
 
   return true;
 }
 
 void testFullPathOnNonExistentDirectory() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentDirectory");
 
   // Full path non-existent directory should throw exception.
   Expect.throws(() => file.fullPathSync(),
                 (e) => checkFullPathOnNonExistentDirectoryException(e));
 
   var fullPathFuture = file.fullPath();
   fullPathFuture.then((path) => Expect.fail("Unreachable code $path"))
   .catchError((error) {
     checkFullPathOnNonExistentDirectoryException(error);
-    p.toSendPort().send(null);
+    temp.deleteSync(recursive: true);
+    asyncEnd();
   });
 }
 
 void testReadAsBytesNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile3");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsBytesSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   var readAsBytesFuture = file.readAsBytes();
   readAsBytesFuture.then((data) => Expect.fail("Unreachable code"))
   .catchError((error) {
     checkOpenNonExistentFileException(error);
-    p.toSendPort().send(null);
+    temp.deleteSync(recursive: true);
+    asyncEnd();
   });
 }
 
 void testReadAsTextNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile4");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsStringSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   var readAsStringFuture = file.readAsString(encoding: ASCII);
   readAsStringFuture.then((data) => Expect.fail("Unreachable code"))
   .catchError((error) {
     checkOpenNonExistentFileException(error);
-    p.toSendPort().send(null);
+    temp.deleteSync(recursive: true);
+    asyncEnd();
   });
 }
 
 testReadAsLinesNonExistent() {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
   var file = new File("${temp.path}/nonExistentFile5");
 
   // Non-existing file should throw exception.
   Expect.throws(() => file.readAsLinesSync(),
                 (e) => checkOpenNonExistentFileException(e));
 
   var readAsLinesFuture = file.readAsLines(encoding: ASCII);
   readAsLinesFuture.then((data) => Expect.fail("Unreachable code"))
   .catchError((error) {
     checkOpenNonExistentFileException(error);
-    p.toSendPort().send(null);
+    temp.deleteSync(recursive: true);
+    asyncEnd();
   });
 }
 
 bool checkWriteReadOnlyFileException(e) {
   Expect.isTrue(e is FileException);
   Expect.isTrue(e.osError != null);
   Expect.isTrue(e.osError.errorCode != OSError.noErrorCode);
   return true;
 }
 
 
 // Create a test file in a temporary directory. Setup a port to signal
 // when the temporary directory should be deleted. Pass the file and
 // the port to the callback argument.
 createTestFile(callback) {
+  asyncStart();
   Directory temp = tempDir();
-  ReceivePort p = new ReceivePort();
-  p.receive((x, y) {
-    p.close();
-    temp.deleteSync(recursive: true);
-  });
-
   var file = new File("${temp.path}/test_file");
   file.createSync();
-  callback(file, p.toSendPort());
+  callback(file, () {
+    temp.deleteSync(recursive: true);
+    asyncEnd();
+  });
 }
 
 
 testWriteByteToReadOnlyFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync(mode: FileMode.READ);
 
     // Writing to read only file should throw an exception.
     Expect.throws(() => openedFile.writeByteSync(0),
                   (e) => checkWriteReadOnlyFileException(e));
 
     var writeByteFuture = openedFile.writeByte(0);
     writeByteFuture.catchError((error) {
       checkWriteReadOnlyFileException(error);
-      openedFile.close().then((ignore) => port.send(null));
+      openedFile.close().then((_) => done());
     });
   });
 }
 
 testWriteFromToReadOnlyFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync(mode: FileMode.READ);
 
     List data = [0, 1, 2, 3];
     // Writing to read only file should throw an exception.
     Expect.throws(() => openedFile.writeFromSync(data, 0, data.length),
                   (e) => checkWriteReadOnlyFileException(e));
 
     var writeFromFuture = openedFile.writeFrom(data, 0, data.length);
     writeFromFuture.catchError((error) {
       checkWriteReadOnlyFileException(error);
-      openedFile.close().then((ignore) => port.send(null));
+      openedFile.close().then((_) => done());
     });
   });
 }
 
 testTruncateReadOnlyFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync(mode: FileMode.WRITE);
     openedFile.writeByteSync(0);
     openedFile.closeSync();
     openedFile = file.openSync(mode: FileMode.READ);
 
     // Truncating read only file should throw an exception.
     Expect.throws(() => openedFile.truncateSync(0),
                   (e) => checkWriteReadOnlyFileException(e));
 
     var truncateFuture = openedFile.truncate(0);
     truncateFuture.then((ignore) => Expect.fail("Unreachable code"))
     .catchError((error) {
       checkWriteReadOnlyFileException(error);
-      openedFile.close().then((ignore) => port.send(null));
+      openedFile.close().then((_) => done());
     });
   });
 }
 
 bool checkFileClosedException(e) {
   Expect.isTrue(e is FileException);
   Expect.isTrue(e.toString().indexOf("File closed") != -1);
   Expect.isTrue(e.osError == null);
   return true;
 }
 
 testOperateOnClosedFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync(mode: FileMode.READ);
     openedFile.closeSync();
 
     List data = [0, 1, 2, 3];
     Expect.throws(() => openedFile.readByteSync(),
                   (e) => checkFileClosedException(e));
     Expect.throws(() => openedFile.writeByteSync(0),
                   (e) => checkFileClosedException(e));
     Expect.throws(() => openedFile.writeFromSync(data, 0, data.length),
                   (e) => checkFileClosedException(e));
@@ skipping 10 matching lines @@
     Expect.throws(() => openedFile.lengthSync(),
                   (e) => checkFileClosedException(e));
     Expect.throws(() => openedFile.flushSync(),
                   (e) => checkFileClosedException(e));
 
     var errorCount = 0;
 
     _errorHandler(error) {
       checkFileClosedException(error);
       if (--errorCount == 0) {
-        port.send(null);
+        done();
       }
     }
 
     var readByteFuture = openedFile.readByte();
     readByteFuture.then((byte) => Expect.fail("Unreachable code"))
     .catchError(_errorHandler);
     errorCount++;
     var writeByteFuture = openedFile.writeByte(0);
     writeByteFuture.then((ignore) => Expect.fail("Unreachable code"))
     .catchError(_errorHandler);
@@ skipping 27 matching lines @@
     .catchError(_errorHandler);
     errorCount++;
     var flushFuture = openedFile.flush();
     flushFuture.then((ignore) => Expect.fail("Unreachable code"))
     .catchError(_errorHandler);
     errorCount++;
 });
 }
 
 testRepeatedlyCloseFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync();
     openedFile.close().then((ignore) {
       var closeFuture = openedFile.close();
       closeFuture.then((ignore) => null)
       .catchError((error) {
         Expect.isTrue(error is FileException);
-        port.send(null);
+        done();
       });
     });
   });
 }
 
 testRepeatedlyCloseFileSync() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync();
     openedFile.closeSync();
     Expect.throws(openedFile.closeSync,
                   (e) => e is FileException);
-    port.send(null);
+    done();
   });
 }
 
 testReadSyncBigInt() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var bigint = 100000000000000000000000000000000000000000;
     var openedFile = file.openSync();
     Expect.throws(() => openedFile.readSync(bigint),
                   (e) => e is FileException);
     openedFile.closeSync();
-    port.send(null);
+    done();
   });
 }
 
 testReadSyncClosedFile() {
-  createTestFile((file, port) {
+  createTestFile((file, done) {
     var openedFile = file.openSync();
     openedFile.closeSync();
     Expect.throws(() => openedFile.readSync(1),
                   (e) => e is FileException);
-    port.send(null);
+    done();
   });
 }
 
 main() {
   testOpenNonExistent();
   testDeleteNonExistent();
   testLengthNonExistent();
   testCreateInNonExistentDirectory();
   testFullPathOnNonExistentDirectory();
   testReadAsBytesNonExistent();
   testReadAsTextNonExistent();
   testReadAsLinesNonExistent();
   testWriteByteToReadOnlyFile();
   testWriteFromToReadOnlyFile();
   testTruncateReadOnlyFile();
   testOperateOnClosedFile();
   testRepeatedlyCloseFile();
   testRepeatedlyCloseFileSync();
   testReadSyncBigInt();
   testReadSyncClosedFile();
 }