Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: tests/standalone/io/regress_7191_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/regress_10026_test.dart ('k') | tests/standalone/io/secure_builtin_roots_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/regress_7191_test.dart
diff --git a/tests/standalone/io/regress_7191_test.dart b/tests/standalone/io/regress_7191_test.dart
index 781f734577b6b8ea44e3d2ee244aadd16b6462c4..1595abe984fb37e1d8916166897ae68b84eea7ed 100644
--- a/tests/standalone/io/regress_7191_test.dart
+++ b/tests/standalone/io/regress_7191_test.dart
@@ -10,11 +10,13 @@
// closed which will make this test hang.
import 'dart:io';
-import 'dart:isolate';
+
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
import 'package:path/path.dart';
main() {
- var port = new ReceivePort();
+ asyncStart();
var executable = Platform.executable;
var script = join(dirname(Platform.script), 'regress_7191_script.dart');
Process.start(executable, [script]).then((process) {
@@ -23,7 +25,7 @@ main() {
onDone: () { process.stdin.add([0]); });
process.stderr.listen((_) { });
process.exitCode.then((exitCode) {
- port.close();
+ asyncEnd();
if (exitCode != 0) throw "Bad exit code";
});
});
« no previous file with comments | « tests/standalone/io/regress_10026_test.dart ('k') | tests/standalone/io/secure_builtin_roots_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698