Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: tests/standalone/io/http_client_request_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_client_request_test.dart
diff --git a/tests/standalone/io/http_client_request_test.dart b/tests/standalone/io/http_client_request_test.dart
index 35d565bf6fc40b46597b5fbca13252a47041a702..0d7da3d6860f32b23813e3a177b182a0ba555713 100644
--- a/tests/standalone/io/http_client_request_test.dart
+++ b/tests/standalone/io/http_client_request_test.dart
@@ -2,12 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
import "dart:io";
-import "dart:isolate";
import "dart:typed_data";
-void testClientRequest(void handler(request)) {
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
+
+void testClientRequest(Future handler(request)) {
HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((request) {
request.listen((_) {}, onDone: () {
@@ -45,61 +46,61 @@ void testResponseDone() {
}
void testBadResponseAdd() {
+ asyncStart();
testClientRequest((request) {
- var port = new ReceivePort();
request.contentLength = 0;
request.add([0]);
request.close();
request.done.catchError((error) {
- port.close();
+ asyncEnd();
}, test: (e) => e is HttpException);
return request.done;
});
+ asyncStart();
testClientRequest((request) {
- var port = new ReceivePort();
request.contentLength = 5;
request.add([0, 0, 0]);
request.add([0, 0, 0]);
request.close();
request.done.catchError((error) {
- port.close();
+ asyncEnd();
}, test: (e) => e is HttpException);
return request.done;
});
+ asyncStart();
testClientRequest((request) {
- var port = new ReceivePort();
request.contentLength = 0;
request.add(new Uint8List(64 * 1024));
request.add(new Uint8List(64 * 1024));
request.add(new Uint8List(64 * 1024));
request.close();
request.done.catchError((error) {
- port.close();
+ asyncEnd();
}, test: (e) => e is HttpException);
return request.done;
});
}
void testBadResponseClose() {
+ asyncStart();
testClientRequest((request) {
- var port = new ReceivePort();
request.contentLength = 5;
request.close();
request.done.catchError((error) {
- port.close();
+ asyncEnd();
}, test: (e) => e is HttpException);
return request.done;
});
+ asyncStart();
testClientRequest((request) {
- var port = new ReceivePort();
request.contentLength = 5;
request.add([0]);
request.close();
request.done.catchError((error) {
- port.close();
+ asyncEnd();
}, test: (e) => e is HttpException);
return request.done;
});
« no previous file with comments | « tests/standalone/io/http_client_exception_test.dart ('k') | tests/standalone/io/http_reuse_server_port_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698