Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tests/standalone/io/regress_7191_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Regression test for http://dartbug.com/7191. 5 // Regression test for http://dartbug.com/7191.
6 6
7 // Starts a sub-process which in turn starts another sub-process and then closes 7 // Starts a sub-process which in turn starts another sub-process and then closes
8 // its standard output. If handles are incorrectly inherited on Windows, this 8 // its standard output. If handles are incorrectly inherited on Windows, this
9 // will lead to a situation where the stdout of the first sub-process is never 9 // will lead to a situation where the stdout of the first sub-process is never
10 // closed which will make this test hang. 10 // closed which will make this test hang.
11 11
12 import 'dart:io'; 12 import 'dart:io';
13 import 'dart:isolate'; 13
14 import "package:async_helper/async_helper.dart";
15 import "package:expect/expect.dart";
14 import 'package:path/path.dart'; 16 import 'package:path/path.dart';
15 17
16 main() { 18 main() {
17 var port = new ReceivePort(); 19 asyncStart();
18 var executable = Platform.executable; 20 var executable = Platform.executable;
19 var script = join(dirname(Platform.script), 'regress_7191_script.dart'); 21 var script = join(dirname(Platform.script), 'regress_7191_script.dart');
20 Process.start(executable, [script]).then((process) { 22 Process.start(executable, [script]).then((process) {
21 process.stdin.add([0]); 23 process.stdin.add([0]);
22 process.stdout.listen((_) { }, 24 process.stdout.listen((_) { },
23 onDone: () { process.stdin.add([0]); }); 25 onDone: () { process.stdin.add([0]); });
24 process.stderr.listen((_) { }); 26 process.stderr.listen((_) { });
25 process.exitCode.then((exitCode) { 27 process.exitCode.then((exitCode) {
26 port.close(); 28 asyncEnd();
27 if (exitCode != 0) throw "Bad exit code"; 29 if (exitCode != 0) throw "Bad exit code";
28 }); 30 });
29 }); 31 });
30 } 32 }
OLDNEW
« no previous file with comments | « tests/standalone/io/regress_10026_test.dart ('k') | tests/standalone/io/secure_builtin_roots_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698