Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: tests/standalone/io/secure_server_client_certificate_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/secure_server_client_certificate_test.dart
diff --git a/tests/standalone/io/secure_server_client_certificate_test.dart b/tests/standalone/io/secure_server_client_certificate_test.dart
index 395aa58929f352b46fd4a39428b433f0cfdddc05..b2e385024bf365ba4098483dcba314915760ea7f 100644
--- a/tests/standalone/io/secure_server_client_certificate_test.dart
+++ b/tests/standalone/io/secure_server_client_certificate_test.dart
@@ -2,17 +2,18 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
-import "package:path/path.dart";
import "dart:async";
import "dart:io";
-import "dart:isolate";
+
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
+import "package:path/path.dart";
const HOST_NAME = "localhost";
const CERTIFICATE = "localhost_cert";
void testClientCertificate() {
- ReceivePort port = new ReceivePort();
+ asyncStart();
SecureServerSocket.bind(HOST_NAME,
0,
CERTIFICATE,
@@ -33,14 +34,14 @@ void testClientCertificate() {
clientEnd.close();
serverEnd.close();
server.close();
- port.close();
+ asyncEnd();
});
});
});
}
void testRequiredClientCertificate() {
- ReceivePort port = new ReceivePort();
+ asyncStart();
SecureServerSocket.bind(HOST_NAME,
0,
CERTIFICATE,
@@ -61,14 +62,14 @@ void testRequiredClientCertificate() {
clientEnd.close();
serverEnd.close();
server.close();
- port.close();
+ asyncEnd();
});
});
});
}
void testNoClientCertificate() {
- ReceivePort port = new ReceivePort();
+ asyncStart();
SecureServerSocket.bind(HOST_NAME,
0,
CERTIFICATE,
@@ -82,14 +83,14 @@ void testNoClientCertificate() {
clientEnd.close();
serverEnd.close();
server.close();
- port.close();
+ asyncEnd();
});
});
});
}
void testNoRequiredClientCertificate() {
- ReceivePort port = new ReceivePort();
+ asyncStart();
bool clientError = false;
SecureServerSocket.bind(HOST_NAME,
0,
@@ -104,7 +105,7 @@ void testNoRequiredClientCertificate() {
clientDone.then((_) {
Expect.isTrue(clientError);
server.close();
- port.close();
+ asyncEnd();
});
});
});
« no previous file with comments | « tests/standalone/io/secure_builtin_roots_test.dart ('k') | tests/standalone/io/secure_server_closing_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698