Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: tests/standalone/io/http_client_exception_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 5
6 import "dart:io";
7
8 import "package:async_helper/async_helper.dart";
6 import "package:expect/expect.dart"; 9 import "package:expect/expect.dart";
7 import "dart:io";
8 import "dart:isolate";
9 10
10 void testInvalidUrl() { 11 void testInvalidUrl() {
11 HttpClient client = new HttpClient(); 12 HttpClient client = new HttpClient();
12 Expect.throws( 13 Expect.throws(
13 () => client.getUrl(Uri.parse('ftp://www.google.com'))); 14 () => client.getUrl(Uri.parse('ftp://www.google.com')));
14 } 15 }
15 16
16 void testBadHostName() { 17 void testBadHostName() {
18 asyncStart();
17 HttpClient client = new HttpClient(); 19 HttpClient client = new HttpClient();
18 ReceivePort port = new ReceivePort();
19 client.get("some.bad.host.name.7654321", 0, "/") 20 client.get("some.bad.host.name.7654321", 0, "/")
20 .then((request) { 21 .then((request) {
21 Expect.fail("Should not open a request on bad hostname"); 22 Expect.fail("Should not open a request on bad hostname");
22 }).catchError((error) { 23 }).catchError((error) {
23 port.close(); // We expect onError to be called, due to bad host name. 24 asyncEnd(); // We expect onError to be called, due to bad host name.
24 }, test: (error) => error is! String); 25 }, test: (error) => error is! String);
25 } 26 }
26 27
27 void main() { 28 void main() {
28 testInvalidUrl(); 29 testInvalidUrl();
29 testBadHostName(); 30 testBadHostName();
30 } 31 }
OLDNEW
« no previous file with comments | « tests/standalone/io/http_client_connect_test.dart ('k') | tests/standalone/io/http_client_request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698