Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: tests/standalone/io/https_client_exception_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/https_client_certificate_test.dart ('k') | tests/standalone/io/link_async_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/https_client_exception_test.dart
diff --git a/tests/standalone/io/https_client_exception_test.dart b/tests/standalone/io/https_client_exception_test.dart
index 6994e05b9fd43ee07321e4e1e112d308dd5a1d81..1f9cbade98ef1846c091ad8360a3f256752e2f5b 100644
--- a/tests/standalone/io/https_client_exception_test.dart
+++ b/tests/standalone/io/https_client_exception_test.dart
@@ -2,19 +2,20 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
import "dart:io";
-import "dart:isolate";
+
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
void testBadHostName() {
+ asyncStart();
HttpClient client = new HttpClient();
- ReceivePort port = new ReceivePort();
client.getUrl(Uri.parse("https://some.bad.host.name.7654321/"))
.then((HttpClientRequest request) {
Expect.fail("Should not open a request on bad hostname");
})
.catchError((error) {
- port.close(); // Should throw an error on bad hostname.
+ asyncEnd(); // Should throw an error on bad hostname.
});
}
« no previous file with comments | « tests/standalone/io/https_client_certificate_test.dart ('k') | tests/standalone/io/link_async_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698