Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: tests/standalone/io/raw_server_socket_cancel_test.dart

Issue 23886004: Update dart:io tests to use asyncStart/asyncEnd (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // VMOptions= 5 // VMOptions=
6 // VMOptions=--short_socket_read 6 // VMOptions=--short_socket_read
7 // VMOptions=--short_socket_write 7 // VMOptions=--short_socket_write
8 // VMOptions=--short_socket_read --short_socket_write 8 // VMOptions=--short_socket_read --short_socket_write
9 9
10 import "package:expect/expect.dart";
11 import "dart:async"; 10 import "dart:async";
12 import "dart:io"; 11 import "dart:io";
13 import "dart:isolate"; 12
13 import "package:async_helper/async_helper.dart";
14 import "package:expect/expect.dart";
14 15
15 void testCancelResubscribeServerSocket(int socketCount, int backlog) { 16 void testCancelResubscribeServerSocket(int socketCount, int backlog) {
16 var acceptCount = 0; 17 var acceptCount = 0;
17 var doneCount = 0; 18 var doneCount = 0;
18 var errorCount = 0; 19 var errorCount = 0;
19 var earlyErrorCount = 0; 20 var earlyErrorCount = 0;
20 21
21 ReceivePort port = new ReceivePort(); 22 asyncStart();
22 23
23 RawServerSocket.bind("127.0.0.1", 0, backlog: backlog).then((server) { 24 RawServerSocket.bind("127.0.0.1", 0, backlog: backlog).then((server) {
24 Expect.isTrue(server.port > 0); 25 Expect.isTrue(server.port > 0);
25 26
26 void checkDone() { 27 void checkDone() {
27 if (doneCount + errorCount + earlyErrorCount == socketCount) { 28 if (doneCount + errorCount + earlyErrorCount == socketCount) {
28 port.close(); 29 asyncEnd();
29 // Be sure to close as subscription.cancel may not be called, if 30 // Be sure to close as subscription.cancel may not be called, if
30 // backlog prevents acceptCount to grow to socketCount / 2. 31 // backlog prevents acceptCount to grow to socketCount / 2.
31 server.close(); 32 server.close();
32 } 33 }
33 } 34 }
34 35
35 var subscription; 36 var subscription;
36 subscription = server.listen((client) { 37 subscription = server.listen((client) {
37 client.writeEventsEnabled = false; 38 client.writeEventsEnabled = false;
38 client.listen((event) { 39 client.listen((event) {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 checkDone(); 104 checkDone();
104 }); 105 });
105 } 106 }
106 }); 107 });
107 } 108 }
108 109
109 void main() { 110 void main() {
110 testCancelResubscribeServerSocket(10, 20); 111 testCancelResubscribeServerSocket(10, 20);
111 testCancelResubscribeServerSocket(20, 5); 112 testCancelResubscribeServerSocket(20, 5);
112 } 113 }
OLDNEW
« no previous file with comments | « tests/standalone/io/raw_secure_server_socket_test.dart ('k') | tests/standalone/io/raw_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698