Issue 12793003: Rename Timer.repeating to Timer.periodic.

Issue 12793003: Rename Timer.repeating to Timer.periodic. (Closed)

Created:
7 years, 9 months ago by floitsch

Modified:
7 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename Timer.repeating to Timer.periodic. Committed: https://code.google.com/p/dart/source/detail?r=19925

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -31 lines)			Patch
M	runtime/bin/vmstats/vmstats.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/lib/timer_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	samples/chat/chat_server_lib.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	samples/swarm/swarm_ui_lib/base/AnimationScheduler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swipe/web/swipe.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/async_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/async/timer.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/timer_impl.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/async_window_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/dromaeo_smoke_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/isolate/timer_cancel2_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/isolate/timer_cancel_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/timer_not_available_test.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/isolate/timer_repeat_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_close_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_connection_close_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_shutdown_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://chromiumcodereview.appspot.com/12793003/diff/1/tests/isolate/timer_not_available_test.dart File tests/isolate/timer_not_available_test.dart (right): https://chromiumcodereview.appspot.com/12793003/diff/1/tests/isolate/timer_not_available_test.dart#newcode20 tests/isolate/timer_not_available_test.dart:20: var t = new Timer.periodic(ms * 10, (_) ...

7 years, 9 months ago (2013-03-13 10:06:05 UTC) #2

floitsch

https://chromiumcodereview.appspot.com/12793003/diff/1/tests/isolate/timer_not_available_test.dart File tests/isolate/timer_not_available_test.dart (right): https://chromiumcodereview.appspot.com/12793003/diff/1/tests/isolate/timer_not_available_test.dart#newcode20 tests/isolate/timer_not_available_test.dart:20: var t = new Timer.periodic(ms * 10, (_) { ...

7 years, 9 months ago (2013-03-13 13:01:53 UTC) #3

floitsch

7 years, 9 months ago (2013-03-13 13:02:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19925 (presubmit successful).

Expand Messages | Collapse Messages