Moves ownership of MenuItemView to MenuRunner as well as responbility

Moves ownership of MenuItemView to MenuRunner as well as responbility
for showing (running) the menu entirely to MenuRunner. This way I can
guarantee if MenuRunner is deleted, the related menu classes aren't
deleted until the nested message loop completes.

BUG=57890
TEST=thorougly test all menus in chrome: bookmarks, wrench menu,
context menu on page, extension menus...
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98179

[Ben Goodger (Google), 2011-08-23 23:20:46]

LGTM.

[sky, 2011-08-24 00:20:09]

I've changed it so RunMenuAt returns a status indicating if it was deleted. I
updated all callers to check this and if the menu was deleted return regardless.
This will hopefully prevent problems in the future.

Care to take another look?

[Ben Goodger (Google), 2011-08-24 23:05:06]

LGTM still.

[Dmitry Polukhin, 2011-08-25 08:53:26]

It looks like this CL broke network menu on Chrome OS. Chrome crashes every time
when I click on network icon on status area. Stack trace:
#0  0x765acf72 in views::MenuRunner::RunMenuAt(views::Widget*,
views::MenuButton*, gfx::Rect const&, views::MenuItemView::AnchorPosition, int)
()
#1  0x747fe068 in chromeos::NetworkMenu::RunMenu(views::View*) ()
#2  0x74417fc6 in chromeos::NetworkMenuButton::RunMenu(views::View*, gfx::Point
const&) ()
#3  0x7659c29a in views::MenuButton::Activate() ()
#4  0x7441e907 in chromeos::StatusAreaButton::Activate() ()
#5  0x7659bf36 in views::MenuButton::OnMousePressed(views::MouseEvent const&) ()
#6  0x765cf582 in views::View::ProcessMousePressed(views::MouseEvent const&,
views::View::DragInfo*) ()
#7  0x765d82aa in views::internal::RootView::OnMousePressed(views::MouseEvent
const&) ()
#8  0x765e6a58 in views::Widget::OnMouseEvent(views::MouseEvent const&) ()
#9  0x765dffc0 in views::NativeWidgetGtk::OnButtonPress(_GtkWidget*,
_GdkEventButton*) ()
#10 0x765da34f in views::NativeWidgetGtk::OnButtonPressThunk(_GtkWidget*,
_GdkEventButton*, void*) ()
#11 0x73821ca2 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#12 0x732f39ab in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#13 0x7330a419 in ?? () from /usr/lib/libgobject-2.0.so.0
#14 0x7330b49d in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#15 0x7330b7fe in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#16 0x7397f266 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#17 0x73818cc8 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#18 0x7381b574 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#19 0x765c3819 in views::AcceleratorHandler::Dispatch(_GdkEvent*) ()
#20 0x74a1e2d9 in base::MessagePumpGtk::EventDispatcher(_GdkEvent*, void*) ()
#21 0x73674c96 in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#22 0x7322314b in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#23 0x73223900 in ?? () from /usr/lib/libglib-2.0.so.0
#24 0x73223aae in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#25 0x74a1dfd1 in base::MessagePumpGtk::RunOnce(_GMainContext*, bool) ()
#26 0x74a1d461 in
base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*,
base::MessagePumpDispatcher*) ()
#27 0x749e60b3 in MessageLoop::RunHandler() ()
#28 0x749e61f9 in MessageLoopForUI::Run(base::MessagePumpDispatcher*) ()
#29 0x73eb3eed in BrowserMain(MainFunctionParams const&) ()
#30 0x73ea5648 in ChromeMain ()
#31 0x73ea6265 in main ()

[Dmitry Polukhin, 2011-08-25 09:01:45]

http://codereview.chromium.org/7720012/diff/7005/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/network_menu.cc (right):

http://codereview.chromium.org/7720012/diff/7005/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/network_menu.cc:1079: if
(menu_runner_->RunMenuAt(source->GetWidget()->GetTopLevelWidget(),
It looks like menu_runner_ is not set to initialized with object.

[Nikita (slow), 2011-08-25 12:02:10]

File an issue to have basic NetworkMenu browser_test for linux_chromeos that
would have caught this regression
http://code.google.com/p/chromium-os/issues/detail?id=19653