Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h
index 770d2b83b6a0ea707a1e642dba8f5f8ddb092c3a..f8b8227191cca9dfa5d40fc79de5a34af93e70b5 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h
@@ -29,6 +29,7 @@ class OSExchangeData;
namespace views {
class MenuButton;
+class MenuRunner;
class Widget;
} // namespace views
@@ -58,11 +59,6 @@ class BookmarkMenuController : public BaseBookmarkModelObserver,
void RunMenuAt(BookmarkBarView* bookmark_bar, bool for_drop);
- // Shows the menu.
- void RunMenuAt(views::MenuButton* button,
- views::MenuItemView::AnchorPosition position,
- bool for_drop);
-
// Hides the menu.
void Cancel();
@@ -119,6 +115,8 @@ class BookmarkMenuController : public BaseBookmarkModelObserver,
// BookmarkMenuController deletes itself as necessary.
virtual ~BookmarkMenuController();
+ scoped_ptr<views::MenuRunner> menu_runner_;
+
scoped_ptr<BookmarkMenuDelegate> menu_delegate_;
// The node we're showing the contents of.

Powered by Google App Engine
This is Rietveld 408576698