Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/infobars/extension_infobar.h" 5 #include "chrome/browser/ui/views/infobars/extension_infobar.h"
6 6
7 #include "chrome/browser/extensions/extension_context_menu_model.h" 7 #include "chrome/browser/extensions/extension_context_menu_model.h"
8 #include "chrome/browser/extensions/extension_host.h" 8 #include "chrome/browser/extensions/extension_host.h"
9 #include "chrome/browser/extensions/extension_infobar_delegate.h" 9 #include "chrome/browser/extensions/extension_infobar_delegate.h"
10 #include "chrome/browser/platform_util.h" 10 #include "chrome/browser/platform_util.h"
11 #include "chrome/browser/ui/views/frame/browser_view.h" 11 #include "chrome/browser/ui/views/frame/browser_view.h"
12 #include "chrome/common/extensions/extension.h" 12 #include "chrome/common/extensions/extension.h"
13 #include "chrome/common/extensions/extension_icon_set.h" 13 #include "chrome/common/extensions/extension_icon_set.h"
14 #include "chrome/common/extensions/extension_resource.h" 14 #include "chrome/common/extensions/extension_resource.h"
15 #include "grit/theme_resources.h" 15 #include "grit/theme_resources.h"
16 #include "ui/base/animation/slide_animation.h" 16 #include "ui/base/animation/slide_animation.h"
17 #include "ui/base/resource/resource_bundle.h" 17 #include "ui/base/resource/resource_bundle.h"
18 #include "ui/gfx/canvas_skia.h" 18 #include "ui/gfx/canvas_skia.h"
19 #include "views/controls/button/menu_button.h" 19 #include "views/controls/button/menu_button.h"
20 #include "views/controls/menu/menu_item_view.h" 20 #include "views/controls/menu/menu_item_view.h"
21 #include "views/controls/menu/menu_model_adapter.h" 21 #include "views/controls/menu/menu_model_adapter.h"
22 #include "views/controls/menu/menu_runner.h"
22 #include "views/widget/widget.h" 23 #include "views/widget/widget.h"
23 24
24 // ExtensionInfoBarDelegate ---------------------------------------------------- 25 // ExtensionInfoBarDelegate ----------------------------------------------------
25 26
26 InfoBar* ExtensionInfoBarDelegate::CreateInfoBar(TabContentsWrapper* owner) { 27 InfoBar* ExtensionInfoBarDelegate::CreateInfoBar(TabContentsWrapper* owner) {
27 return new ExtensionInfoBar(owner, this); 28 return new ExtensionInfoBar(owner, this);
28 } 29 }
29 30
30 // ExtensionInfoBar ------------------------------------------------------------ 31 // ExtensionInfoBar ------------------------------------------------------------
31 32
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 const Extension* extension = GetDelegate()->extension_host()->extension(); 142 const Extension* extension = GetDelegate()->extension_host()->extension();
142 if (!extension->ShowConfigureContextMenus()) 143 if (!extension->ShowConfigureContextMenus())
143 return; 144 return;
144 145
145 Browser* browser = BrowserView::GetBrowserViewForNativeWindow( 146 Browser* browser = BrowserView::GetBrowserViewForNativeWindow(
146 platform_util::GetTopLevel(source->GetWidget()->GetNativeView()))-> 147 platform_util::GetTopLevel(source->GetWidget()->GetNativeView()))->
147 browser(); 148 browser();
148 scoped_refptr<ExtensionContextMenuModel> options_menu_contents = 149 scoped_refptr<ExtensionContextMenuModel> options_menu_contents =
149 new ExtensionContextMenuModel(extension, browser, NULL); 150 new ExtensionContextMenuModel(extension, browser, NULL);
150 views::MenuModelAdapter options_menu_delegate(options_menu_contents.get()); 151 views::MenuModelAdapter options_menu_delegate(options_menu_contents.get());
151 views::MenuItemView options_menu(&options_menu_delegate); 152 views::MenuRunner options_menu_runner(options_menu_delegate.CreateMenu());
152 options_menu_delegate.BuildMenu(&options_menu);
153 153
154 gfx::Point screen_point; 154 gfx::Point screen_point;
155 views::View::ConvertPointToScreen(menu_, &screen_point); 155 views::View::ConvertPointToScreen(menu_, &screen_point);
156 options_menu.RunMenuAt(GetWidget(), menu_, 156 if (options_menu_runner.RunMenuAt(GetWidget(), menu_,
157 gfx::Rect(screen_point, menu_->size()), views::MenuItemView::TOPLEFT, 157 gfx::Rect(screen_point, menu_->size()), views::MenuItemView::TOPLEFT,
158 true); 158 views::MenuRunner::HAS_MNEMONICS) == views::MenuRunner::MENU_DELETED)
159 return;
159 } 160 }
160 161
161 ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() { 162 ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() {
162 return delegate_ ? delegate_->AsExtensionInfoBarDelegate() : NULL; 163 return delegate_ ? delegate_->AsExtensionInfoBarDelegate() : NULL;
163 } 164 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698