Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/browser/chromeos/login/language_switch_menu.h

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/language_switch_menu.h
diff --git a/chrome/browser/chromeos/login/language_switch_menu.h b/chrome/browser/chromeos/login/language_switch_menu.h
index 2b99a66003df68c8f124c12d1326095008af69d5..c1681f6f7a3dc0fece2d8de9a9830debbff2acaf 100644
--- a/chrome/browser/chromeos/login/language_switch_menu.h
+++ b/chrome/browser/chromeos/login/language_switch_menu.h
@@ -18,6 +18,7 @@ class WizardControllerTest_SwitchLanguage_Test;
namespace views {
class MenuItemView;
+class MenuRunner;
} // namespace views
namespace chromeos {
@@ -58,8 +59,11 @@ class LanguageSwitchMenu : public views::ViewMenuDelegate,
// views::MenuDelegate implementation.
virtual void ExecuteCommand(int command_id) OVERRIDE;
- // Dialog controls that we own ourselves.
- scoped_ptr<views::MenuItemView> menu_;
+ // The menu.
+ views::MenuItemView* menu_;
+
+ // Runs and owns |menu_|.
+ scoped_ptr<views::MenuRunner> menu_runner_;
// Language locale name storage.
scoped_ptr<LanguageList> language_list_;

Powered by Google App Engine
This is Rietveld 408576698