Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: chrome/browser/chromeos/status/clock_menu_button.h

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/status/clock_menu_button.h
diff --git a/chrome/browser/chromeos/status/clock_menu_button.h b/chrome/browser/chromeos/status/clock_menu_button.h
index 7864b972b75c62c9b814e5ce2a0b13ae3a9affde..ac712c75e1b362936057169d61e40436732b87eb 100644
--- a/chrome/browser/chromeos/status/clock_menu_button.h
+++ b/chrome/browser/chromeos/status/clock_menu_button.h
@@ -21,7 +21,7 @@
#include "views/controls/menu/view_menu_delegate.h"
namespace views {
-class MenuItemView;
+class MenuRunner;
}
namespace chromeos {
@@ -80,9 +80,7 @@ class ClockMenuButton : public StatusAreaButton,
base::OneShotTimer<ClockMenuButton> timer_;
// The clock menu.
- // NOTE: we use a scoped_ptr here as menu calls into 'this' from the
- // constructor.
- scoped_ptr<views::MenuItemView> menu_;
+ scoped_ptr<views::MenuRunner> menu_runner_;
PrefChangeRegistrar registrar_;

Powered by Google App Engine
This is Rietveld 408576698