chrome/browser/ui/views/toolbar_view.cc - Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc

index 1452c96e61822c332ddc3e88db05a7b5efed6138..337635ead04bff3f7a4a05d99d9648ce51f1112b 100644

--- a/chrome/browser/ui/views/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar_view.cc

@@ -328,7 +328,7 @@ bool ToolbarView::GetAcceleratorInfo(int id, ui::Accelerator* accel) {

void ToolbarView::RunMenu(views::View* source, const gfx::Point& /* pt */) {

DCHECK_EQ(VIEW_ID_APP_MENU, source->id());

- wrench_menu_ = new WrenchMenu(browser_);

+ wrench_menu_.reset(new WrenchMenu(browser_));

wrench_menu_->Init(wrench_menu_model_.get());

for (size_t i = 0; i < menu_listeners_.size(); ++i)