Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: views/controls/combobox/native_combobox_views.h

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/combobox/native_combobox_views.h
diff --git a/views/controls/combobox/native_combobox_views.h b/views/controls/combobox/native_combobox_views.h
index f4cb56baab4cea9bdc66bf73e2080bcbda9a7f7e..5722e96697fa4974702f92f57bcab6502068c45f 100644
--- a/views/controls/combobox/native_combobox_views.h
+++ b/views/controls/combobox/native_combobox_views.h
@@ -19,6 +19,7 @@ namespace views {
class KeyEvent;
class FocusableBorder;
+class MenuRunner;
// A views/skia only implementation of NativeComboboxWrapper.
// No platform specific code is used.
@@ -82,8 +83,8 @@ class NativeComboboxViews : public views::View,
// The reference to the border class. The object is owned by View::border_.
FocusableBorder* text_border_;
- // Context menu and its content list for the combobox.
- scoped_ptr<views::MenuItemView> dropdown_list_menu_;
+ // Responsible for showing the context menu.
+ scoped_ptr<MenuRunner> dropdown_list_menu_runner_;
// Is the drop down list showing
bool dropdown_open_;

Powered by Google App Engine
This is Rietveld 408576698