Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
index d9c4e7555125b8d8d850c196581efed5f2c392ab..9a834328f9f8c2eaef835a345b66da02a94c3198 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
@@ -17,6 +17,7 @@ class BrowserActionsContainer;
class BrowserActionView;
namespace views {
+class MenuRunner;
class Widget;
}
@@ -90,8 +91,11 @@ class BrowserActionOverflowMenuController : public views::MenuDelegate {
// A pointer to the overflow menu button that we are showing the menu for.
views::MenuButton* menu_button_;
- // The overflow menu for the menu button.
- scoped_ptr<views::MenuItemView> menu_;
+ // The overflow menu for the menu button. Owned by |menu_runner_|.
+ views::MenuItemView* menu_;
+
+ // Resposible for running the menu.
+ scoped_ptr<views::MenuRunner> menu_runner_;
// The views vector of all the browser actions the container knows about. We
// won't show all items, just the one starting at |start_index| and above.

Powered by Google App Engine
This is Rietveld 408576698