chrome/browser/ui/views/compact_nav/compact_options_bar.cc - Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/compact_nav/compact_options_bar.cc

Issue 7720012: Moves ownership of MenuItemView to MenuRunner as well as responbility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/compact_nav/compact_options_bar.cc

diff --git a/chrome/browser/ui/views/compact_nav/compact_options_bar.cc b/chrome/browser/ui/views/compact_nav/compact_options_bar.cc

index bcf5b143f1fbdb87ee574f38e4adc22b14be82aa..5ba008f465ceb3f02c7c005203056ccd3f724e1a 100644

--- a/chrome/browser/ui/views/compact_nav/compact_options_bar.cc

+++ b/chrome/browser/ui/views/compact_nav/compact_options_bar.cc

@@ -94,7 +94,7 @@ void CompactOptionsBar::RunMenu(views::View* source,

const gfx::Point& /* pt */) {

DCHECK_EQ(VIEW_ID_APP_MENU, source->id());

- wrench_menu_ = new WrenchMenu(browser_view_->browser());

+ wrench_menu_.reset(new WrenchMenu(browser_view_->browser()));

wrench_menu_->Init(wrench_menu_model_.get());

for (size_t i = 0; i < menu_listeners_.size(); ++i)