Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5577003: Coverity: Pass parameters by reference. (Closed)

Created:
10 years ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, ben+cc_chromium.org, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Coverity: Pass parameters by reference. CID=8391,8392,8526,8527,11212,11213,12566,12567, 12610,12611,13934,13935,13936,13937 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68374

Patch Set 1 #

Patch Set 2 : Unit test fix. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M chrome/browser/sync/glue/autofill_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator2.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/preference_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
10 years ago (2010-12-04 01:44:37 UTC) #1
Lei Zhang
Compile fail. Please ask someone who works on sync to review this?
10 years ago (2010-12-04 03:19:32 UTC) #2
ncarter (slow)
I'm fine with the idea behind this change. On Fri, Dec 3, 2010 at 10:19 ...
10 years ago (2010-12-04 06:04:19 UTC) #3
James Hawkins
Nick has signed off, and the CL passed the trybots. Please run through this again. ...
10 years ago (2010-12-06 18:14:51 UTC) #4
Lei Zhang
10 years ago (2010-12-06 19:30:37 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698