chrome/browser/sync/glue/session_model_associator.cc - Issue 5577003: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/session_model_associator.cc

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/session_model_associator.cc

diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc

index a77c92d7b0708c6a50ed656d93fa7249c1fe7c35..1efe37af6f22c7815da859d3d298fbc70590d147 100644

--- a/chrome/browser/sync/glue/session_model_associator.cc

+++ b/chrome/browser/sync/glue/session_model_associator.cc

@@ -99,7 +99,7 @@ bool SessionModelAssociator::GetSyncIdForTaggedNode(const std::string* tag,

return true;

}

-int64 SessionModelAssociator::GetSyncIdFromChromeId(std::string id) {

+int64 SessionModelAssociator::GetSyncIdFromChromeId(const std::string& id) {

sync_api::ReadTransaction trans(

sync_service_->backend()->GetUserShareHandle());

sync_api::ReadNode node(&trans);