Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/sync/glue/typed_url_model_associator.h

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_model_associator.h
diff --git a/chrome/browser/sync/glue/typed_url_model_associator.h b/chrome/browser/sync/glue/typed_url_model_associator.h
index a07bae91d05903065eb7044fd9faa44a42a00cfc..ca875c9b8ea8d088a6eb83226f172925f697ba3f 100644
--- a/chrome/browser/sync/glue/typed_url_model_associator.h
+++ b/chrome/browser/sync/glue/typed_url_model_associator.h
@@ -84,14 +84,14 @@ class TypedUrlModelAssociator
}
// Not implemented.
- virtual bool InitSyncNodeFromChromeId(std::string node_id,
+ virtual bool InitSyncNodeFromChromeId(const std::string& node_id,
sync_api::BaseNode* sync_node) {
return false;
}
// Returns the sync id for the given typed_url name, or sync_api::kInvalidId
// if the typed_url name is not associated to any sync id.
- virtual int64 GetSyncIdFromChromeId(std::string node_id);
+ virtual int64 GetSyncIdFromChromeId(const std::string& node_id);
// Associates the given typed_url name with the given sync id.
virtual void Associate(const std::string* node, int64 sync_id);
« no previous file with comments | « chrome/browser/sync/glue/session_model_associator.cc ('k') | chrome/browser/sync/glue/typed_url_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698