chrome/browser/sync/glue/preference_model_associator.cc - Issue 5577003: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/preference_model_associator.cc

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/preference_model_associator.cc

diff --git a/chrome/browser/sync/glue/preference_model_associator.cc b/chrome/browser/sync/glue/preference_model_associator.cc

index feedcef91530ad9e960bc472e73810255d3fd63c..da6ca37c890e862177e538a4d26258ec202ccafa 100644

--- a/chrome/browser/sync/glue/preference_model_associator.cc

+++ b/chrome/browser/sync/glue/preference_model_associator.cc

@@ -166,7 +166,7 @@ bool PreferenceModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) {

}

int64 PreferenceModelAssociator::GetSyncIdFromChromeId(

- const std::string preference_name) {

+ const std::string& preference_name) {

PreferenceNameToSyncIdMap::const_iterator iter =

id_map_.find(preference_name);

return iter == id_map_.end() ? sync_api::kInvalidId : iter->second;