Coverity: Pass parameters by reference.

chrome/browser/sync/glue/autofill_model_associator2.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/autofill_model_associator2.h"
 
 #include <vector>
 
 #include "base/task.h"
 #include "base/time.h"
@@ skipping 403 matching lines @@
   AutoLock lock(abort_association_pending_lock_);
   abort_association_pending_ = true;
 }
 
 const std::string*
 AutofillModelAssociator2::GetChromeNodeFromSyncId(int64 sync_id) {
   return NULL;
 }
 
 bool AutofillModelAssociator2::InitSyncNodeFromChromeId(
-    std::string node_id,
+    const std::string& node_id,
     sync_api::BaseNode* sync_node) {
   return false;
 }
 
 int64 AutofillModelAssociator2::GetSyncIdFromChromeId(
-    const std::string autofill) {
+    const std::string& autofill) {
   AutofillToSyncIdMap::const_iterator iter = id_map_.find(autofill);
   return iter == id_map_.end() ? sync_api::kInvalidId : iter->second;
 }
 
 void AutofillModelAssociator2::Associate(
     const std::string* autofill, int64 sync_id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
   DCHECK_NE(sync_api::kInvalidId, sync_id);
   DCHECK(id_map_.find(*autofill) == id_map_.end());
   DCHECK(id_map_inverse_.find(sync_id) == id_map_inverse_.end());
@@ skipping 97 matching lines @@
   diff = MergeField2(p, COMPANY_NAME, s.company_name()) || diff;
   diff = MergeField2(p, PHONE_FAX_WHOLE_NUMBER, s.phone_fax_whole_number())
       || diff;
   diff = MergeField2(p, PHONE_HOME_WHOLE_NUMBER, s.phone_home_whole_number())
       || diff;
   return diff;
 }
 
 }  // namespace browser_sync