Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/sync/glue/autofill_model_associator.h

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/sync/glue/autofill_model_associator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_
6 #define CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 // than the permanent tagged nodes. 75 // than the permanent tagged nodes.
76 virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); 76 virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes);
77 77
78 // See ModelAssociator interface. 78 // See ModelAssociator interface.
79 virtual void AbortAssociation(); 79 virtual void AbortAssociation();
80 80
81 // Not implemented. 81 // Not implemented.
82 virtual const std::string* GetChromeNodeFromSyncId(int64 sync_id); 82 virtual const std::string* GetChromeNodeFromSyncId(int64 sync_id);
83 83
84 // Not implemented. 84 // Not implemented.
85 virtual bool InitSyncNodeFromChromeId(std::string node_id, 85 virtual bool InitSyncNodeFromChromeId(const std::string& node_id,
86 sync_api::BaseNode* sync_node); 86 sync_api::BaseNode* sync_node);
87 87
88 // Returns the sync id for the given autofill name, or sync_api::kInvalidId 88 // Returns the sync id for the given autofill name, or sync_api::kInvalidId
89 // if the autofill name is not associated to any sync id. 89 // if the autofill name is not associated to any sync id.
90 virtual int64 GetSyncIdFromChromeId(std::string node_id); 90 virtual int64 GetSyncIdFromChromeId(const std::string& node_id);
91 91
92 // Associates the given autofill name with the given sync id. 92 // Associates the given autofill name with the given sync id.
93 virtual void Associate(const std::string* node, int64 sync_id); 93 virtual void Associate(const std::string* node, int64 sync_id);
94 94
95 // Remove the association that corresponds to the given sync id. 95 // Remove the association that corresponds to the given sync id.
96 virtual void Disassociate(int64 sync_id); 96 virtual void Disassociate(int64 sync_id);
97 97
98 // Returns whether a node with the given permanent tag was found and update 98 // Returns whether a node with the given permanent tag was found and update
99 // |sync_id| with that node's id. 99 // |sync_id| with that node's id.
100 virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id); 100 virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id);
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 // AssociateModels method as soon as possible. 207 // AssociateModels method as soon as possible.
208 Lock abort_association_pending_lock_; 208 Lock abort_association_pending_lock_;
209 bool abort_association_pending_; 209 bool abort_association_pending_;
210 210
211 DISALLOW_COPY_AND_ASSIGN(AutofillModelAssociator); 211 DISALLOW_COPY_AND_ASSIGN(AutofillModelAssociator);
212 }; 212 };
213 213
214 } // namespace browser_sync 214 } // namespace browser_sync
215 215
216 #endif // CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_ 216 #endif // CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/glue/autofill_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698