Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/browser/sync/glue/model_associator.h

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/model_associator.h
diff --git a/chrome/browser/sync/glue/model_associator.h b/chrome/browser/sync/glue/model_associator.h
index f74129f94ba148e7d82a2c526ab646d80bff7727..7d8f9851b4c5395e399d9e51b16eb3d234af3a5b 100644
--- a/chrome/browser/sync/glue/model_associator.h
+++ b/chrome/browser/sync/glue/model_associator.h
@@ -60,7 +60,7 @@ class PerDataTypeAssociatorInterface : public AssociatorInterface {
// Returns sync id for the given chrome model id.
// Returns sync_api::kInvalidId if the sync node is not found for the given
// chrome id.
- virtual int64 GetSyncIdFromChromeId(IDType id) = 0;
+ virtual int64 GetSyncIdFromChromeId(const IDType& id) = 0;
// Returns the chrome node for the given sync id.
// Returns NULL if no node is found for the given sync id.
@@ -69,7 +69,7 @@ class PerDataTypeAssociatorInterface : public AssociatorInterface {
// Initializes the given sync node from the given chrome node id.
// Returns false if no sync node was found for the given chrome node id or
// if the initialization of sync node fails.
- virtual bool InitSyncNodeFromChromeId(IDType node_id,
+ virtual bool InitSyncNodeFromChromeId(const IDType& node_id,
sync_api::BaseNode* sync_node) = 0;
// Associates the given chrome node with the given sync id.
« no previous file with comments | « chrome/browser/sync/glue/bookmark_model_associator.cc ('k') | chrome/browser/sync/glue/password_model_associator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698