Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6082)

Unified Diff: chrome/browser/sync/glue/session_model_associator.h

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/session_model_associator.h
diff --git a/chrome/browser/sync/glue/session_model_associator.h b/chrome/browser/sync/glue/session_model_associator.h
index 89d30be679ff7f53a913d9781adca9902129c5d8..b10d29035164f3451062c5444c6dbd7f42e4723d 100644
--- a/chrome/browser/sync/glue/session_model_associator.h
+++ b/chrome/browser/sync/glue/session_model_associator.h
@@ -93,14 +93,14 @@ class SessionModelAssociator : public PerDataTypeAssociatorInterface<
// Returns sync id for the given chrome model id.
// Returns sync_api::kInvalidId if the sync node is not found for the given
// chrome id.
- virtual int64 GetSyncIdFromChromeId(std::string id);
+ virtual int64 GetSyncIdFromChromeId(const std::string& id);
// Initializes the given sync node from the given chrome node id.
// Returns false if no sync node was found for the given chrome node id or
// if the initialization of sync node fails.
- virtual bool InitSyncNodeFromChromeId(std::string id,
- sync_api::BaseNode* sync_node) {
+ virtual bool InitSyncNodeFromChromeId(const std::string& id,
+ sync_api::BaseNode* sync_node) {
return false;
}
« no previous file with comments | « chrome/browser/sync/glue/preference_model_associator.cc ('k') | chrome/browser/sync/glue/session_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698