Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/sync/glue/autofill_model_associator2.h

Issue 5577003: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_
6 #define CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 // than the permanent tagged nodes. 74 // than the permanent tagged nodes.
75 virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); 75 virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes);
76 76
77 // See ModelAssociator interface. 77 // See ModelAssociator interface.
78 virtual void AbortAssociation(); 78 virtual void AbortAssociation();
79 79
80 // Not implemented. 80 // Not implemented.
81 virtual const std::string* GetChromeNodeFromSyncId(int64 sync_id); 81 virtual const std::string* GetChromeNodeFromSyncId(int64 sync_id);
82 82
83 // Not implemented. 83 // Not implemented.
84 virtual bool InitSyncNodeFromChromeId(std::string node_id, 84 virtual bool InitSyncNodeFromChromeId(const std::string& node_id,
85 sync_api::BaseNode* sync_node); 85 sync_api::BaseNode* sync_node);
86 86
87 // Returns the sync id for the given autofill name, or sync_api::kInvalidId 87 // Returns the sync id for the given autofill name, or sync_api::kInvalidId
88 // if the autofill name is not associated to any sync id. 88 // if the autofill name is not associated to any sync id.
89 virtual int64 GetSyncIdFromChromeId(std::string node_id); 89 virtual int64 GetSyncIdFromChromeId(const std::string& node_id);
90 90
91 // Associates the given autofill name with the given sync id. 91 // Associates the given autofill name with the given sync id.
92 virtual void Associate(const std::string* node, int64 sync_id); 92 virtual void Associate(const std::string* node, int64 sync_id);
93 93
94 // Remove the association that corresponds to the given sync id. 94 // Remove the association that corresponds to the given sync id.
95 virtual void Disassociate(int64 sync_id); 95 virtual void Disassociate(int64 sync_id);
96 96
97 // Returns whether a node with the given permanent tag was found and update 97 // Returns whether a node with the given permanent tag was found and update
98 // |sync_id| with that node's id. 98 // |sync_id| with that node's id.
99 virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id); 99 virtual bool GetSyncIdForTaggedNode(const std::string& tag, int64* sync_id);
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 Lock abort_association_pending_lock_; 203 Lock abort_association_pending_lock_;
204 bool abort_association_pending_; 204 bool abort_association_pending_;
205 205
206 DISALLOW_COPY_AND_ASSIGN(AutofillModelAssociator2); 206 DISALLOW_COPY_AND_ASSIGN(AutofillModelAssociator2);
207 }; 207 };
208 208
209 } // namespace browser_sync 209 } // namespace browser_sync
210 210
211 #endif // CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_ 211 #endif // CHROME_BROWSER_SYNC_GLUE_AUTOFILL_MODEL_ASSOCIATOR2_H_
212 212
OLDNEW
« no previous file with comments | « chrome/browser/sync/glue/autofill_model_associator.cc ('k') | chrome/browser/sync/glue/autofill_model_associator2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698