Cleanup AdjustStringForLocaleDirection()

Cleanup AdjustStringForLocaleDirection() to modify input parameter in place.

As described in the bug, the current behavior is confusing and bug-prone.

BUG=47194
TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67237

[Avi (use Gerrit), 2010-11-23 16:07:08]

http://codereview.chromium.org/5154009/diff/6001/base/i18n/rtl.h
File base/i18n/rtl.h (right):

http://codereview.chromium.org/5154009/diff/6001/base/i18n/rtl.h#newcode76
base/i18n/rtl.h:76: // (either left-to-right or right-to-left).The function
checks both the current
nit: space after period

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/chromeos/dom_...
File chrome/browser/chromeos/dom_ui/system_settings_provider.cc (right):

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/chromeos/dom_...
chrome/browser/chromeos/dom_ui/system_settings_provider.cc:277: return
rtl_safe_result;
So the original code was wrong :). Drop the use of rtl_safe_result, and just run
result through Adjust. Avoid a copy.

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/language_comb...
File chrome/browser/language_combobox_model.cc (right):

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/language_comb...
chrome/browser/language_combobox_model.cc:93: std::wstring
locale_name_localized;
This string is no longer needed. Delete.

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/possible_url_...
File chrome/browser/possible_url_model.cc (right):

http://codereview.chromium.org/5154009/diff/6001/chrome/browser/possible_url_...
chrome/browser/possible_url_model.cc:139: std::wstring localized_title = title;
You're making a copy anyway; clearer to just make |title| a wstring (no const,
no reference) above and skip the variable here.

[Avi (use Gerrit), 2010-11-23 16:34:33]

LGTM with those changes.