Cleanup AdjustStringForLocaleDirection()

chrome/browser/dom_ui/dom_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/dom_ui.h"
 
 #include "base/i18n/rtl.h"
 #include "base/json/json_writer.h"
 #include "base/stl_util-inl.h"
 #include "base/string_number_conversions.h"
@@ skipping 161 matching lines @@
 
   // Since the title can contain BiDi text, we need to mark the text as either
   // RTL or LTR, depending on the characters in the string. If we use the URL
   // as the title, we mark the title as LTR since URLs are always treated as
   // left to right strings.
   string16 title_to_set(title);
   if (base::i18n::IsRTL()) {
     if (using_url_as_the_title) {
       base::i18n::WrapStringWithLTRFormatting(&title_to_set);
     } else {
-      bool success =
-          base::i18n::AdjustStringForLocaleDirection(title, &title_to_set);
-      DCHECK(success ? (title != title_to_set) : (title == title_to_set));
+      base::i18n::AdjustStringForLocaleDirection(&title_to_set);
     }
   }
   dictionary->SetString("title", title_to_set);
 }
 
 bool DOMMessageHandler::ExtractIntegerValue(const ListValue* value,
                                             int* out_int) {
   std::string string_value;
   if (value->GetString(0, &string_value))
     return base::StringToInt(string_value, out_int);
   NOTREACHED();
   return false;
 }
 
 // TODO(viettrungluu): convert to string16 (or UTF-8 std::string?).
 std::wstring DOMMessageHandler::ExtractStringValue(const ListValue* value) {
   string16 string16_value;
   if (value->GetString(0, &string16_value))
     return UTF16ToWideHack(string16_value);
   NOTREACHED();
   return std::wstring();
 }