Cleanup AdjustStringForLocaleDirection()

chrome/browser/possible_url_model.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/possible_url_model.h"
 
 #include "app/resource_bundle.h"
 #include "app/table_model_observer.h"
 #include "app/text_elider.h"
 #include "base/callback.h"
@@ skipping 118 matching lines @@
   if (row < 0 || row >= RowCount()) {
     NOTREACHED();
     return std::wstring();
   }
 
   if (col_id == IDS_ASI_PAGE_COLUMN) {
     const std::wstring& title = GetTitle(row);
     // TODO(xji): Consider adding a special case if the title text is a URL,
     // since those should always have LTR directionality. Please refer to
     // http://crbug.com/6726 for more information.
-    std::wstring localized_title;
-    if (base::i18n::AdjustStringForLocaleDirection(title, &localized_title))
-      return localized_title;
-    return title;
+    std::wstring localized_title = title;

[Avi (use Gerrit), 2010/11/23 16:07:08]

You're making a copy anyway; clearer to just make |title| a wstring (no const,
no reference) above and skip the variable here.

+    base::i18n::AdjustStringForLocaleDirection(&localized_title);
+    return localized_title;
   }
 
   // TODO(brettw): this should probably pass the GURL up so the URL elider
   // can be used at a higher level when we know the width.
   string16 url = results_[row].display_url.display_url();
   return UTF16ToWide(base::i18n::GetDisplayStringInLTRDirectionality(url));
 }
 
 SkBitmap PossibleURLModel::GetIcon(int row) {
   if (row < 0 || row >= RowCount()) {
@@ skipping 50 matching lines @@
       // Notify the observer.
       if (!fav_icon_map_[index].isNull() && observer_)
         observer_->OnItemsChanged(static_cast<int>(index), 1);
     }
   }
 }
 
 void PossibleURLModel::SetObserver(TableModelObserver* observer) {
   observer_ = observer;
 }