chrome/browser/ui/views/bookmark_bar_view.cc - Issue 5154009: Cleanup AdjustStringForLocaleDirection()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmark_bar_view.cc

Issue 5154009: Cleanup AdjustStringForLocaleDirection() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: further fixes Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmark_bar_view.cc

index 439df1dbeb572a9e90ae247b8739eb10917a1667..6226524a6009adb51389817602f17f3c373469dd 100644

--- a/chrome/browser/ui/views/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmark_bar_view.cc

@@ -143,9 +143,8 @@ static std::wstring CreateToolTipForURLAndTitle(const gfx::Point& screen_loc,

// First the title.

if (!title.empty()) {

- std::wstring localized_title;

- if (!base::i18n::AdjustStringForLocaleDirection(title, &localized_title))

- localized_title = title;

+ std::wstring localized_title = title;

+ base::i18n::AdjustStringForLocaleDirection(&localized_title);

result.append(UTF16ToWideHack(gfx::ElideText(WideToUTF16Hack(

localized_title), tt_font, max_width, false)));

}