chrome/browser/dom_ui/dom_ui.cc - Issue 5154009: Cleanup AdjustStringForLocaleDirection()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/dom_ui.cc

Issue 5154009: Cleanup AdjustStringForLocaleDirection() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: further fixes Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/dom_ui.cc

diff --git a/chrome/browser/dom_ui/dom_ui.cc b/chrome/browser/dom_ui/dom_ui.cc

index e6481b6a12e418dd758478e6a7885f246814fc58..06c7d2d3c70e97d41555e7c27ac7a7eba561ecb0 100644

--- a/chrome/browser/dom_ui/dom_ui.cc

+++ b/chrome/browser/dom_ui/dom_ui.cc

@@ -179,9 +179,7 @@ void DOMMessageHandler::SetURLAndTitle(DictionaryValue* dictionary,

if (using_url_as_the_title) {

base::i18n::WrapStringWithLTRFormatting(&title_to_set);

} else {

- bool success =

- base::i18n::AdjustStringForLocaleDirection(title, &title_to_set);

- DCHECK(success ? (title != title_to_set) : (title == title_to_set));

+ base::i18n::AdjustStringForLocaleDirection(&title_to_set);

}

dictionary->SetString("title", title_to_set);