Cleanup AdjustStringForLocaleDirection()

chrome/browser/possible_url_model.cc

Index: chrome/browser/possible_url_model.cc
diff --git a/chrome/browser/possible_url_model.cc b/chrome/browser/possible_url_model.cc
index f4197626ec138ee46a22d12995cc972b88ec36f6..b0f9e0e020f839fac02c159242c88dfdb12dd9b1 100644
--- a/chrome/browser/possible_url_model.cc
+++ b/chrome/browser/possible_url_model.cc
@@ -136,10 +136,9 @@ std::wstring PossibleURLModel::GetText(int row, int col_id) {
     // TODO(xji): Consider adding a special case if the title text is a URL,
     // since those should always have LTR directionality. Please refer to
     // http://crbug.com/6726 for more information.
-    std::wstring localized_title;
-    if (base::i18n::AdjustStringForLocaleDirection(title, &localized_title))
-      return localized_title;
-    return title;
+    std::wstring localized_title = title;

[Avi (use Gerrit), 2010/11/23 16:07:08]

You're making a copy anyway; clearer to just make |title| a wstring (no const,
no reference) above and skip the variable here.

+    base::i18n::AdjustStringForLocaleDirection(&localized_title);
+    return localized_title;
   }
 
   // TODO(brettw): this should probably pass the GURL up so the URL elider