Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 5154009: Cleanup AdjustStringForLocaleDirection() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: further fixes Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/possible_url_model.cc ('K') | « chrome/common/extensions/extension.cc ('k') | gfx/canvas_skia_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_unittest.cc
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index 3f86bbd3f75bde0a16f719225a33305ec8d96cb3..013fce713a012760de4b274fcaef40ce926d7887 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -383,7 +383,7 @@ TEST(ExtensionTest, InitFromValueValidNameInRTL) {
EXPECT_TRUE(extension.InitFromValue(input_value, false, &error));
EXPECT_EQ("", error);
std::wstring localized_name(name);
- base::i18n::AdjustStringForLocaleDirection(localized_name, &localized_name);
+ base::i18n::AdjustStringForLocaleDirection(&localized_name);
EXPECT_EQ(localized_name, UTF8ToWide(extension.name()));
// Strong RTL characters in name.
@@ -392,7 +392,7 @@ TEST(ExtensionTest, InitFromValueValidNameInRTL) {
EXPECT_TRUE(extension.InitFromValue(input_value, false, &error));
EXPECT_EQ("", error);
localized_name = name;
- base::i18n::AdjustStringForLocaleDirection(localized_name, &localized_name);
+ base::i18n::AdjustStringForLocaleDirection(&localized_name);
EXPECT_EQ(localized_name, UTF8ToWide(extension.name()));
// Reset locale.
« chrome/browser/possible_url_model.cc ('K') | « chrome/common/extensions/extension.cc ('k') | gfx/canvas_skia_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698