chrome/browser/chromeos/dom_ui/system_settings_provider.cc - Issue 5154009: Cleanup AdjustStringForLocaleDirection()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/dom_ui/system_settings_provider.cc

Issue 5154009: Cleanup AdjustStringForLocaleDirection() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: further fixes Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/dom_ui/system_settings_provider.cc

diff --git a/chrome/browser/chromeos/dom_ui/system_settings_provider.cc b/chrome/browser/chromeos/dom_ui/system_settings_provider.cc

index cbf54a27fc59ae3216ded03e966aa145547e34f4..9dbf0b36b708e5320a9b573cd6fc321947a5a36c 100644

--- a/chrome/browser/chromeos/dom_ui/system_settings_provider.cc

+++ b/chrome/browser/chromeos/dom_ui/system_settings_provider.cc

@@ -273,7 +273,7 @@ string16 SystemSettingsProvider::GetTimezoneName(

IDS_OPTIONS_SETTINGS_TIMEZONE_DISPLAY_TEMPLATE, ASCIIToUTF16(offset_str),

string16(name.getBuffer(), name.length()), GetExemplarCity(timezone)));

string16 rtl_safe_result = result;

- base::i18n::AdjustStringForLocaleDirection(result, &rtl_safe_result);

+ base::i18n::AdjustStringForLocaleDirection(&rtl_safe_result);

return rtl_safe_result;

Avi (use Gerrit) 2010/11/23 16:07:08 So the original code was wrong :). Drop the use of

}