views/controls/tree/tree_view.cc - Issue 5154009: Cleanup AdjustStringForLocaleDirection()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/tree/tree_view.cc

Issue 5154009: Cleanup AdjustStringForLocaleDirection() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: further fixes Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/tree/tree_view.cc

diff --git a/views/controls/tree/tree_view.cc b/views/controls/tree/tree_view.cc

index 6b02a62fbb04195d4c036980b5220ad8297cf9e5..bfdd454d6460e522172d9315f17699866e1823de 100644

--- a/views/controls/tree/tree_view.cc

+++ b/views/controls/tree/tree_view.cc

@@ -370,9 +370,7 @@ LRESULT TreeView::OnNotify(int w_param, LPNMHDR l_param) {

DCHECK(info->item.cchTextMax);

// Adjust the string direction if such adjustment is required.

- std::wstring localized_text;

- if (base::i18n::AdjustStringForLocaleDirection(text, &localized_text))

- text.swap(localized_text);

+ base::i18n::AdjustStringForLocaleDirection(&text);

wcsncpy_s(info->item.pszText, info->item.cchTextMax, text.c_str(),

_TRUNCATE);