Issue 31008: Coalesce more hardcoded schemes to using predefined constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 31008: Coalesce more hardcoded schemes to using predefined constants. (Closed)

Created:
11 years, 10 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Coalesce more hardcoded schemes to using predefined constants. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10437

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -94 lines)			Patch
M	chrome/browser/autocomplete/history_url_provider.cc	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/back_forward_menu_model_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browsing_instance.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_contents.cc	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension.cc	View	1	3 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_protocols.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/history/visit_database.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/importer/firefox2_importer.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/importer/ie_importer.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_fixer_upper.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/buffered_resource_handler.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/renderer_security_policy.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_model.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_parser.cc	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_policy.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/site_instance.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	chrome/common/extensions/url_pattern.cc	View		4 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+15 lines, -1 line	0 comments	Download
	chrome/common/url_constants.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
	chrome/plugin/webplugin_proxy.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages