chrome/browser/download/save_package.cc - Issue 31008: Coalesce more hardcoded schemes to using predefined constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_package.cc

Issue 31008: Coalesce more hardcoded schemes to using predefined constants. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/save_package.cc

===================================================================

--- chrome/browser/download/save_package.cc (revision 10345)

+++ chrome/browser/download/save_package.cc (working copy)

@@ -28,6 +28,7 @@

#include "chrome/common/pref_names.h"

#include "chrome/common/pref_service.h"

#include "chrome/common/stl_util-inl.h"

+#include "chrome/common/url_constants.h"

#include "grit/generated_resources.h"

#include "net/base/io_buffer.h"

#include "net/base/mime_util.h"

@@ -1068,8 +1069,10 @@

// Static

bool SavePackage::IsSavableURL(const GURL& url) {

- return url.SchemeIs("http") || url.SchemeIs("https") ||

- url.SchemeIs("file") || url.SchemeIs("ftp");

+ return url.SchemeIs(chrome::kHttpScheme) ||

+ url.SchemeIs(chrome::kHttpsScheme) ||

+ url.SchemeIs(chrome::kFileScheme) ||

+ url.SchemeIs(chrome::kFtpScheme);

}

// Static

« no previous file with comments | « chrome/browser/dom_ui/dom_ui_contents.cc ('k') | chrome/browser/extensions/extension.h » ('j') | no next file with comments »