Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/site_instance.cc

Issue 31008: Coalesce more hardcoded schemes to using predefined constants. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu_controller.cc ('k') | chrome/browser/tab_contents/web_contents_view_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/site_instance.cc
===================================================================
--- chrome/browser/tab_contents/site_instance.cc (revision 10345)
+++ chrome/browser/tab_contents/site_instance.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/tab_contents/site_instance.h"
#include "chrome/browser/renderer_host/browser_render_process_host.h"
+#include "chrome/common/url_constants.h"
#include "net/base/registry_controlled_domain.h"
SiteInstance::~SiteInstance() {
@@ -124,7 +125,8 @@
// We must treat javascript: URLs as part of the same site, regardless of
// the site.
- if (url1.SchemeIs("javascript") || url2.SchemeIs("javascript"))
+ if (url1.SchemeIs(chrome::kJavaScriptScheme) ||
+ url2.SchemeIs(chrome::kJavaScriptScheme))
return true;
// We treat about:crash, about:hang, and about:shorthang as the same site as
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu_controller.cc ('k') | chrome/browser/tab_contents/web_contents_view_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698