Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1897)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/importer/firefox2_importer.cc

Issue 31008: Coalesce more hardcoded schemes to using predefined constants. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/visit_database.cc ('k') | chrome/browser/importer/ie_importer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/firefox2_importer.cc
===================================================================
--- chrome/browser/importer/firefox2_importer.cc (revision 10345)
+++ chrome/browser/importer/firefox2_importer.cc (working copy)
@@ -15,6 +15,7 @@
#include "chrome/browser/search_engines/template_url_parser.h"
#include "chrome/common/l10n_util.h"
#include "chrome/common/time_format.h"
+#include "chrome/common/url_constants.h"
#include "grit/generated_resources.h"
#include "net/base/data_url.h"
@@ -527,7 +528,7 @@
const GURL& favicon_data,
std::vector<history::ImportedFavIconUsage>* favicons) {
if (!link_url.is_valid() || !favicon_data.is_valid() ||
- !favicon_data.SchemeIs("data"))
+ !favicon_data.SchemeIs(chrome::kDataScheme))
return;
// Parse the data URL.
« no previous file with comments | « chrome/browser/history/visit_database.cc ('k') | chrome/browser/importer/ie_importer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698