Coalesce more hardcoded schemes to using predefined constants.

chrome/browser/tab_contents/site_instance.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/site_instance.h"
 
 #include "chrome/browser/renderer_host/browser_render_process_host.h"
+#include "chrome/common/url_constants.h"
 #include "net/base/registry_controlled_domain.h"
 
 SiteInstance::~SiteInstance() {
   // Now that no one is referencing us, we can safely remove ourselves from
   // the BrowsingInstance.  Any future visits to a page from this site
   // (within the same BrowsingInstance) can safely create a new SiteInstance.
   if (has_site_)
     browsing_instance_->UnregisterSiteInstance(this);
 }
 
@@ skipping 99 matching lines @@
 
 /*static*/
 bool SiteInstance::IsSameWebSite(const GURL& url1, const GURL& url2) {
   // We infer web site boundaries based on the registered domain name of the
   // top-level page and the scheme.  We do not pay attention to the port if
   // one is present, because pages served from different ports can still
   // access each other if they change their document.domain variable.
 
   // We must treat javascript: URLs as part of the same site, regardless of
   // the site.
-  if (url1.SchemeIs("javascript") || url2.SchemeIs("javascript"))
+  if (url1.SchemeIs(chrome::kJavaScriptScheme) ||
+      url2.SchemeIs(chrome::kJavaScriptScheme))
     return true;
 
   // We treat about:crash, about:hang, and about:shorthang as the same site as
   // any URL, since they are used as demos for crashing/hanging a process.
   GURL about_crash = GURL("about:crash");
   GURL about_hang = GURL("about:hang");
   GURL about_shorthang = GURL("about:shorthang");
   if (url1 == about_crash || url2 == about_crash ||
           url1 == about_hang || url2 == about_hang ||
           url1 == about_shorthang || url2 == about_shorthang)
     return true;
 
   // If either URL is invalid, they aren't part of the same site.
   if (!url1.is_valid() || !url2.is_valid()) {
     return false;
   }
 
   // If the schemes differ, they aren't part of the same site.
   if (url1.scheme() != url2.scheme()) {
     return false;
   }
 
   return net::RegistryControlledDomainService::SameDomainOrHost(url1, url2);
 }