Coalesce more hardcoded schemes to using predefined constants.

chrome/browser/search_engines/template_url_parser.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search_engines/template_url_parser.h"
 
 #include <map>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 #include "chrome/browser/search_engines/template_url.h"
+#include "chrome/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "libxml/parser.h"
 #include "libxml/xmlwriter.h"
 
 namespace {
 
 //
 // NOTE: libxml uses the UTF-8 encoding. As 0-127 of UTF-8 corresponds
 // to that of char, the following names are all in terms of char. This avoids
 // having to convert to wide, then do comparisons
@@ skipping 451 matching lines @@
   ParsingContext* context = reinterpret_cast<ParsingContext*>(ctx);
   switch (context->GetKnownType()) {
     case ParsingContext::SHORT_NAME:
       context->template_url()->set_short_name(context->GetString());
       break;
     case ParsingContext::DESCRIPTION:
       context->template_url()->set_description(context->GetString());
       break;
     case ParsingContext::IMAGE: {
       GURL image_url(WideToUTF8(context->GetString()));
-      if (image_url.SchemeIs("data")) {
+      if (image_url.SchemeIs(chrome::kDataScheme)) {
         // TODO (jcampan): bug 1169256: when dealing with data URL, we need to
         // decode the data URL in the renderer. For now, we'll just point to the
         // fav icon from the URL.
         context->set_derive_image_from_url(true);
       } else {
         context->SetImageURL(context->GetString());
       }
       context->EndImage();
       break;
     }
@@ skipping 20 matching lines @@
   ParsingContext* context = reinterpret_cast<ParsingContext*>(ctx);
   context->AppendString(XMLCharToWide(ch, len));
 }
 
 // Returns true if the ref is null, or the url wrapped by ref is
 // valid with a spec of http/https.
 bool IsHTTPRef(const TemplateURLRef* ref) {
   if (ref == NULL)
     return true;
   GURL url(WideToUTF8(ref->url()));
-  return (url.is_valid() && (url.SchemeIs("http") || url.SchemeIs("https")));
+  return (url.is_valid() && (url.SchemeIs(chrome::kHttpScheme) ||
+                             url.SchemeIs(chrome::kHttpsScheme)));
 }
 
 // Returns true if the TemplateURL is legal. A legal TemplateURL is one
 // where all URLs have a spec of http/https.
 bool IsLegal(TemplateURL* url) {
   if (!IsHTTPRef(url->url()) || !IsHTTPRef(url->suggestions_url()))
     return false;
   // Make sure all the image refs are legal.
   const std::vector<TemplateURL::ImageRef>& image_refs = url->image_refs();
   for (size_t i = 0; i < image_refs.size(); i++) {
     GURL image_url(image_refs[i].url);
     if (!image_url.is_valid() ||
-        !(image_url.SchemeIs("http") || image_url.SchemeIs("https"))) {
+        !(image_url.SchemeIs(chrome::kHttpScheme) ||
+          image_url.SchemeIs(chrome::kHttpsScheme))) {
       return false;
     }
   }
   return true;
 }
 
 } // namespace
 
 // static
 bool TemplateURLParser::Parse(const unsigned char* data, size_t length,
@@ skipping 27 matching lines @@
     url->SetSuggestionsURL(L"", 0, 0);
 
   if (!url->short_name().empty() && !url->description().empty()) {
     // So far so good, make sure the urls are http.
     return IsLegal(url);
   }
   return false;
 }