Coalesce more hardcoded schemes to using predefined constants.

chrome/browser/renderer_host/renderer_security_policy.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/renderer_security_policy.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "chrome/common/url_constants.h"
 #ifdef CHROME_PERSONALIZATION
@@ skipping 60 matching lines @@
   // The set of files the renderer is permited to upload to the web.
   FileSet uploadable_files_;
 
   bool has_dom_ui_bindings_;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityState);
 };
 
 RendererSecurityPolicy::RendererSecurityPolicy() {
   // We know about these schemes and believe them to be safe.
-  RegisterWebSafeScheme("http");
-  RegisterWebSafeScheme("https");
-  RegisterWebSafeScheme("ftp");
-  RegisterWebSafeScheme("data");
+  RegisterWebSafeScheme(chrome::kHttpScheme);
+  RegisterWebSafeScheme(chrome::kHttpsScheme);
+  RegisterWebSafeScheme(chrome::kFtpScheme);
+  RegisterWebSafeScheme(chrome::kDataScheme);
   RegisterWebSafeScheme("feed");
   RegisterWebSafeScheme("chrome-extension");
 
   // We know about the following psuedo schemes and treat them specially.
   RegisterPseudoScheme(chrome::kAboutScheme);
   RegisterPseudoScheme(chrome::kJavaScriptScheme);
   RegisterPseudoScheme(chrome::kViewSourceScheme);
 }
 
 // static
@@ skipping 54 matching lines @@
 
   if (!url.is_valid())
     return;  // Can't grant the capability to request invalid URLs.
 
   if (IsWebSafeScheme(url.scheme()))
     return;  // The scheme has already been white-listed for every renderer.
 
   if (IsPseudoScheme(url.scheme())) {
     // The view-source scheme is a special case of a pseudo URL that eventually
     // results in requesting its embedded URL.
-    if (url.SchemeIs("view-source")) {
+    if (url.SchemeIs(chrome::kViewSourceScheme)) {
       // URLs with the view-source scheme typically look like:
       //   view-source:http://www.google.com/a
       // In order to request these URLs, the renderer needs to be able to request
       // the embedded URL.
       GrantRequestURL(renderer_id, GURL(url.path()));
     }
 
     return;  // Can't grant the capability to request pseudo schemes.
   }
 
@@ skipping 22 matching lines @@
 
 void RendererSecurityPolicy::GrantInspectElement(int renderer_id) {
   AutoLock lock(lock_);
 
   SecurityStateMap::iterator state = security_state_.find(renderer_id);
   if (state == security_state_.end())
     return;
 
   // The inspector is served from a chrome-ui: URL.  In order to run the
   // inspector, the renderer needs to be able to load chrome-ui URLs.
-  state->second->GrantScheme("chrome-ui");
+  state->second->GrantScheme(chrome::kChromeUIScheme);
 }
 
 void RendererSecurityPolicy::GrantDOMUIBindings(int renderer_id) {
   AutoLock lock(lock_);
 
   SecurityStateMap::iterator state = security_state_.find(renderer_id);
   if (state == security_state_.end())
     return;
 
   state->second->GrantDOMUIBindings();
 
   // DOM UI bindings need the ability to request chrome-ui URLs.
-  state->second->GrantScheme("chrome-ui");
+  state->second->GrantScheme(chrome::kChromeUIScheme);
 
   // DOM UI pages can contain links to file:// URLs.
-  state->second->GrantScheme("file");
+  state->second->GrantScheme(chrome::kFileScheme);
 }
 
 bool RendererSecurityPolicy::CanRequestURL(int renderer_id, const GURL& url) {
   if (!url.is_valid())
     return false;  // Can't request invalid URLs.
 
   if (IsWebSafeScheme(url.scheme()))
     return true;  // The scheme has been white-listed for every renderer.
 
   if (IsPseudoScheme(url.scheme())) {
     // There are a number of special cases for pseudo schemes.
 
-    if (url.SchemeIs("view-source")) {
+    if (url.SchemeIs(chrome::kViewSourceScheme)) {
       // A view-source URL is allowed if the renderer is permitted to request
       // the embedded URL.
       return CanRequestURL(renderer_id, GURL(url.path()));
     }
 
-    if (LowerCaseEqualsASCII(url.spec(), "about:blank"))
+    if (LowerCaseEqualsASCII(url.spec(), chrome::kAboutBlankURL))
       return true;  // Every renderer can request <about:blank>.
 
     // URLs like <about:memory> and <about:crash> shouldn't be requestable by
     // any renderer.  Also, this case covers <javascript:...>, which should be
     // handled internally by the renderer and not kicked up to the browser.
     return false;
   }
 
 #ifdef CHROME_PERSONALIZATION
   if (url.SchemeIs(kPersonalizationScheme))
@@ skipping 30 matching lines @@
 bool RendererSecurityPolicy::HasDOMUIBindings(int renderer_id) {
   AutoLock lock(lock_);
 
   SecurityStateMap::iterator state = security_state_.find(renderer_id);
   if (state == security_state_.end())
     return false;
 
   return state->second->has_dom_ui_bindings();
 }