Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6747)

Unified Diff: chrome/browser/ssl/ssl_policy.cc

Issue 31008: Coalesce more hardcoded schemes to using predefined constants. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_policy.cc
===================================================================
--- chrome/browser/ssl/ssl_policy.cc (revision 10345)
+++ chrome/browser/ssl/ssl_policy.cc (working copy)
@@ -20,6 +20,7 @@
#include "chrome/common/resource_bundle.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/time_format.h"
+#include "chrome/common/url_constants.h"
#include "grit/browser_resources.h"
#include "grit/generated_resources.h"
#include "net/base/cert_status_flags.h"
@@ -376,8 +377,9 @@
ResourceType::Type resource_type,
int ssl_cert_id, int ssl_cert_status) {
// These schemes never leave the browser and don't require a warning.
- if (url.SchemeIs("data") || url.SchemeIs("javascript") ||
- url.SchemeIs("about"))
+ if (url.SchemeIs(chrome::kDataScheme) ||
+ url.SchemeIs(chrome::kJavaScriptScheme) ||
+ url.SchemeIs(chrome::kAboutScheme))
return;
NavigationEntry* entry = manager->controller()->GetActiveEntry();

Powered by Google App Engine
This is Rietveld 408576698