Coalesce more hardcoded schemes to using predefined constants.

chrome/browser/ssl/ssl_policy.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_policy.h"
 
 #include "base/singleton.h"
 #include "base/string_piece.h"
 #include "base/string_util.h"
 #include "chrome/browser/cert_store.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/ssl/ssl_error_info.h"
 #include "chrome/browser/tab_contents/navigation_entry.h"
 #include "chrome/browser/tab_contents/web_contents.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/common/resource_bundle.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/time_format.h"
+#include "chrome/common/url_constants.h"
 #include "grit/browser_resources.h"
 #include "grit/generated_resources.h"
 #include "net/base/cert_status_flags.h"
 #include "net/base/ssl_info.h"
 #include "webkit/glue/console_message_level.h"
 #include "webkit/glue/resource_type.h"
 
 #if defined(OS_WIN)
 // TODO(port): port these files.
 #include "chrome/browser/tab_contents/tab_contents.h"
@@ skipping 336 matching lines @@
 void SSLPolicy::OnCertError(const GURL& main_frame_url,
                             SSLManager::CertError* error) {
   // Default to secure behavior.
   error->CancelRequest();
 }
 
 void SSLPolicy::OnRequestStarted(SSLManager* manager, const GURL& url,
                                  ResourceType::Type resource_type,
                                  int ssl_cert_id, int ssl_cert_status) {
   // These schemes never leave the browser and don't require a warning.
-  if (url.SchemeIs("data") || url.SchemeIs("javascript") ||
-      url.SchemeIs("about"))
+  if (url.SchemeIs(chrome::kDataScheme) ||
+      url.SchemeIs(chrome::kJavaScriptScheme) ||
+      url.SchemeIs(chrome::kAboutScheme))
     return;
 
   NavigationEntry* entry = manager->controller()->GetActiveEntry();
   if (!entry) {
     // We may not have an entry for cases such as the inspector.
     return;
   }
 
   NavigationEntry::SSLStatus& ssl = entry->ssl();
   bool changed = false;
@@ skipping 91 matching lines @@
 void SSLPolicy::OnFatalCertError(const GURL& main_frame_url,
                                  SSLManager::CertError* error) {
   if (error->resource_type() != ResourceType::MAIN_FRAME) {
     error->DenyRequest();
     return;
   }
   error->CancelRequest();
   ShowErrorPage(this, error);
   // No need to degrade our security indicators because we didn't continue.
 }