[chromium-reviews] Add Compact Language Detection (CLD) library to Chrome. This works in Windows...

Add Compact Language Detection (CLD) library to Chrome. This works in Windows only currently.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18445

[sidchat (Google), 2009-06-11 00:30:05]

OK, so another brand new CL, scrubbed to make it acceptable for public, and
moved to third_party. The chrome.gyp file contains warning suppressions, which
is something which is necessary to make this work with Chrome. I have not
included unit tests yet with this library. Once in the public trunk, I will add
unittests to cover the APIs that we will be using from this library.

[sgk, 2009-06-11 13:48:52]

lgtm, modulo keeping the dependencies lists sorted (where they already are)

http://codereview.chromium.org/122007/diff/1/78
File build/all.gyp (right):

http://codereview.chromium.org/122007/diff/1/78#newcode60
Line 60: '../third_party/cld/cld.gyp:*',
keep the list sorted, move this line down with the other third_party entries

http://codereview.chromium.org/122007/diff/1/80
File chrome/chrome.gyp (right):

http://codereview.chromium.org/122007/diff/1/80#newcode3747
Line 3747: '../third_party/cld/cld.gyp:cld',
this list is sorted too, move this down with the other ../third_party lines

http://codereview.chromium.org/122007/diff/1/80#newcode3816
Line 3816: '../third_party/cld/cld.gyp:cld',
...and sort here too

[sidchat (Google), 2009-06-11 23:06:24]

Did another round of cleaning. Sorted the entries in .gyp files. Removed some
redundant files from third_party/cld/base.

Please have a look again.

-Sid

On 2009/06/11 13:48:52, sgk wrote:
> lgtm, modulo keeping the dependencies lists sorted (where they already are)
> 
> http://codereview.chromium.org/122007/diff/1/78
> File build/all.gyp (right):
> 
> http://codereview.chromium.org/122007/diff/1/78#newcode60
> Line 60: '../third_party/cld/cld.gyp:*',
> keep the list sorted, move this line down with the other third_party entries
> 
> http://codereview.chromium.org/122007/diff/1/80
> File chrome/chrome.gyp (right):
> 
> http://codereview.chromium.org/122007/diff/1/80#newcode3747
> Line 3747: '../third_party/cld/cld.gyp:cld',
> this list is sorted too, move this down with the other ../third_party lines
> 
> http://codereview.chromium.org/122007/diff/1/80#newcode3816
> Line 3816: '../third_party/cld/cld.gyp:cld',
> ...and sort here too

[brettw, 2009-06-11 23:37:45]

LGTM

[EEstrella198, 2016-09-10 10:34:27]

eestrella198@gmail.com changed reviewers:
+ EEstrella198@gmail.com

[EEstrella198, 2016-09-10 10:34:28]

God is love

[JohnGladue19, 2016-10-13 14:30:45]

johngladue19@gmail.com changed reviewers:
+ JohnGladue19@gmail.com, eestrella198@gmail.com
- EEstrella198@gmail.com

[JohnGladue19, 2016-10-13 14:30:46]

lgtm