Split nested namespaces declaration in two lines in accordance with C++ Style Guide.

Split nested namespaces declaration in two lines in accordance with C++ Style Guide.

This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact.

Committed: http://code.google.com/p/v8/source/detail?r=2038

[Mikhail Naganov, 2009-05-25 09:12:19]

Hi Kasper,

I think Mads should review this issue, but he is on I/O. This is a purely
mechanical change done using sed to split "namespace foo { namespace bar {"
declarations in two lines to conform to C++ Style Guide. Previously I sent a
letter to team asking if all are OK with such change, and no one objected.

[Kasper Lund, 2009-05-25 09:20:32]

Redirecting to Mads for review.

[Mads Ager (chromium), 2009-05-25 09:49:56]

LGTM.

http://codereview.chromium.org/115756/diff/1/3
File src/accessors.h (right):

http://codereview.chromium.org/115756/diff/1/3#newcode104
Line 104: } }  // namespace v8::internal
Shouldn't we fix this as well or is it usual to have these on the same line?

}  // namespace internal
}  // namespace v8

[Mikhail Naganov, 2009-05-25 09:59:34]

Thanks, Mads!

http://codereview.chromium.org/115756/diff/1/3
File src/accessors.h (right):

http://codereview.chromium.org/115756/diff/1/3#newcode104
Line 104: } }  // namespace v8::internal
On 2009/05/25 09:49:56, Mads Ager wrote:
> Shouldn't we fix this as well or is it usual to have these on the same line?
> 
> }  // namespace internal
> }  // namespace v8
> 

Craig Silverstein said that there's no agreement on this part yet. I've checked
Google's codebase---both 2-line and 1-line styles are used, so our style is OK
(at least for now). Personally, I like it more that 2-line style.