Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/messages.h

Issue 115756: Split nested namespaces declaration in two lines in accordance with C++ Style Guide. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 // 29 //
30 // Note: there's a big unresolved issue about ownership of the data 30 // Note: there's a big unresolved issue about ownership of the data
31 // structures used by this framework. 31 // structures used by this framework.
32 32
33 #ifndef V8_MESSAGES_H_ 33 #ifndef V8_MESSAGES_H_
34 #define V8_MESSAGES_H_ 34 #define V8_MESSAGES_H_
35 35
36 #include "handles-inl.h" 36 #include "handles-inl.h"
37 37
38 // Forward declaration of MessageLocation. 38 // Forward declaration of MessageLocation.
39 namespace v8 { namespace internal { 39 namespace v8 {
40 namespace internal {
40 class MessageLocation; 41 class MessageLocation;
41 } } // namespace v8::internal 42 } } // namespace v8::internal
42 43
43 44
44 class V8Message { 45 class V8Message {
45 public: 46 public:
46 V8Message(char* type, 47 V8Message(char* type,
47 v8::internal::Handle<v8::internal::JSArray> args, 48 v8::internal::Handle<v8::internal::JSArray> args,
48 const v8::internal::MessageLocation* loc) : 49 const v8::internal::MessageLocation* loc) :
49 type_(type), args_(args), loc_(loc) { } 50 type_(type), args_(args), loc_(loc) { }
50 char* type() const { return type_; } 51 char* type() const { return type_; }
51 v8::internal::Handle<v8::internal::JSArray> args() const { return args_; } 52 v8::internal::Handle<v8::internal::JSArray> args() const { return args_; }
52 const v8::internal::MessageLocation* loc() const { return loc_; } 53 const v8::internal::MessageLocation* loc() const { return loc_; }
53 private: 54 private:
54 char* type_; 55 char* type_;
55 v8::internal::Handle<v8::internal::JSArray> const args_; 56 v8::internal::Handle<v8::internal::JSArray> const args_;
56 const v8::internal::MessageLocation* loc_; 57 const v8::internal::MessageLocation* loc_;
57 }; 58 };
58 59
59 60
60 namespace v8 { namespace internal { 61 namespace v8 {
62 namespace internal {
61 63
62 struct Language; 64 struct Language;
63 class SourceInfo; 65 class SourceInfo;
64 66
65 class MessageLocation { 67 class MessageLocation {
66 public: 68 public:
67 MessageLocation(Handle<Script> script, 69 MessageLocation(Handle<Script> script,
68 int start_pos, 70 int start_pos,
69 int end_pos) 71 int end_pos)
70 : script_(script), 72 : script_(script),
(...skipping 30 matching lines...) Expand all
101 103
102 static void DefaultMessageReport(const MessageLocation* loc, 104 static void DefaultMessageReport(const MessageLocation* loc,
103 Handle<Object> message_obj); 105 Handle<Object> message_obj);
104 static Handle<String> GetMessage(Handle<Object> data); 106 static Handle<String> GetMessage(Handle<Object> data);
105 static SmartPointer<char> GetLocalizedMessage(Handle<Object> data); 107 static SmartPointer<char> GetLocalizedMessage(Handle<Object> data);
106 }; 108 };
107 109
108 } } // namespace v8::internal 110 } } // namespace v8::internal
109 111
110 #endif // V8_MESSAGES_H_ 112 #endif // V8_MESSAGES_H_
OLDNEW
« src/accessors.h ('K') | « src/memory.h ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698