Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 984153002: Fix template angle bracket syntax in animation (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
dstockwell
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in animation In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -86 lines) Patch
M Source/core/animation/Animation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationStack.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/InterpolableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffectTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 22 chunks +22 lines, -22 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/SampledEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSTimingData.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-06 21:42:38 UTC) #2
dstockwell
lgtm
5 years, 9 months ago (2015-03-09 02:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984153002/1
5 years, 9 months ago (2015-03-09 02:33:36 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 04:09:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191508

Powered by Google App Engine
This is Rietveld 408576698